[PATCH] D48086: [MIRParser] Update a diagnostic message to use the correct register sigil. NFC

[Matt Davis via Phabricator via llvm-commits]

mattd created this revision.
mattd added a reviewer: zer0.

Patch r323922 changed the sigil for physical registers to '$',  instead of '%'.
An error message was missed during this change, and reports the wrong sigil.
This patch corrects that diagnostic and the tests that check that error string.


https://reviews.llvm.org/D48086

Files:
  lib/CodeGen/MIRParser/MIParser.cpp
  test/CodeGen/MIR/X86/expected-different-implicit-operand.mir
  test/CodeGen/MIR/X86/expected-different-implicit-register-flag.mir
  test/CodeGen/MIR/X86/missing-implicit-operand.mir


Index: test/CodeGen/MIR/X86/missing-implicit-operand.mir
===================================================================
--- test/CodeGen/MIR/X86/missing-implicit-operand.mir
+++ test/CodeGen/MIR/X86/missing-implicit-operand.mir
@@ -27,7 +27,7 @@
 
     $eax = MOV32rm $rdi, 1, _, 0, _
     CMP32ri8 $eax, 10, implicit-def $eflags
-  ; CHECK: [[@LINE+1]]:20: missing implicit register operand 'implicit %eflags'
+  ; CHECK: [[@LINE+1]]:20: missing implicit register operand 'implicit $eflags'
     JG_1 %bb.2.exit
 
   bb.1.less:
Index: test/CodeGen/MIR/X86/expected-different-implicit-register-flag.mir
===================================================================
--- test/CodeGen/MIR/X86/expected-different-implicit-register-flag.mir
+++ test/CodeGen/MIR/X86/expected-different-implicit-register-flag.mir
@@ -23,7 +23,7 @@
   bb.0.entry:
     $eax = MOV32rm $rdi, 1, _, 0, _
     CMP32ri8 $eax, 10, implicit-def $eflags
-  ; CHECK: [[@LINE+1]]:42: missing implicit register operand 'implicit %eflags'
+  ; CHECK: [[@LINE+1]]:42: missing implicit register operand 'implicit $eflags'
     JG_1 %bb.2.exit, implicit-def $eflags
 
   bb.1.less:
Index: test/CodeGen/MIR/X86/expected-different-implicit-operand.mir
===================================================================
--- test/CodeGen/MIR/X86/expected-different-implicit-operand.mir
+++ test/CodeGen/MIR/X86/expected-different-implicit-operand.mir
@@ -23,7 +23,7 @@
   bb.0.entry:
     $eax = MOV32rm $rdi, 1, _, 0, _
     CMP32ri8 $eax, 10, implicit-def $eflags
-  ; CHECK: [[@LINE+1]]:35: missing implicit register operand 'implicit %eflags'
+  ; CHECK: [[@LINE+1]]:35: missing implicit register operand 'implicit $eflags'
     JG_1 %bb.2.exit, implicit $eax
 
   bb.1.less:
Index: lib/CodeGen/MIRParser/MIParser.cpp
===================================================================
--- lib/CodeGen/MIRParser/MIParser.cpp
+++ lib/CodeGen/MIRParser/MIParser.cpp
@@ -929,7 +929,7 @@
       continue;
     return error(Operands.empty() ? Token.location() : Operands.back().End,
                  Twine("missing implicit register operand '") +
-                     printImplicitRegisterFlag(I) + " %" +
+                     printImplicitRegisterFlag(I) + " $" +
                      getRegisterName(TRI, I.getReg()) + "'");
   }
   return false;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48086.150982.patch
Type: text/x-patch
Size: 2321 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180612/773a395e/attachment.bin>