[PATCH] D47491: Expand constrained FP operations
Cameron McInally via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 12 09:15:17 PDT 2018
cameron.mcinally added a comment.
In https://reviews.llvm.org/D47491#1129736, @craig.topper wrote:
> It feels like we should be testing non-splat vectors here so we get two calls to the library functions in the output. Rather than one call and a reuse of the result.
Ok, that seems reasonable...
Would you be okay with somewhat random input to the upper operation? It should be okay functionally, since only the first trap is reported. I ask since it can be tricky to find inputs that can trap for each of the different operations. There are finicky details that are unique to each operation. Seems unnecessarily cumbersome IMO. Thoughts?
Repository:
rL LLVM
https://reviews.llvm.org/D47491
More information about the llvm-commits
mailing list