[PATCH] D47969: [Verifier] Check that ValueAsMetadata belongs to the module

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith added subscribers: aprantl, mehdi_amini, rtereshin.
dexonsmith added a comment.

IIRC, sharing uniqued metadata across modules should only happen as a temporary state.  It's a trick for when loading modules that will be merged together, to avoid unnecessarily creating multiple copies of the graphs.

I feel like the verifier should reject this state, unless it's specifically being called in a context where modules-to-be-merged are still being loaded.


Repository:
  rL LLVM

https://reviews.llvm.org/D47969