[PATCH] D47985: [CostModel] Replace ShuffleKind::SK_Alternate with ShuffleKind::SK_Select (PR33744)

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: include/llvm/Analysis/TargetTransformInfo.h:644
     SK_Reverse,         ///< Reverse the order of the vector.
-    SK_Alternate,       ///< Choose alternate elements from vector.
+    SK_Select,          ///< Select either vectors' element from that lane.
     SK_Transpose,       ///< Transpose two vectors.
----------------
A bit more description would be good here. Something like:
Selects elements from the corresponding lane of one source operand or the other. This is equivalent to a vector select with a constant condition operand.


================
Comment at: lib/Analysis/TargetTransformInfo.cpp:678
+static bool isSelectVectorMask(ArrayRef<int> Mask) {
+  bool isSelect = true;
+  bool FoundLHS = false;
----------------
Formatting: IsSelect.


Repository:
  rL LLVM

https://reviews.llvm.org/D47985