[PATCH] D47955: [SampleFDO] Add a new compact binary format for sample profile

[Wei Mi via llvm-commits]

On Mon, Jun 11, 2018 at 7:24 PM, Douglas Yung via Phabricator <
reviews at reviews.llvm.org> wrote:

> dyung added inline comments.
>
>
> ================
> Comment at: llvm/trunk/tools/llvm-profdata/llvm-profdata.cpp:478
> +          clEnumValN(PF_Compact_Binary, "compbinary",
> +                     "Compact binary encoding (default)"),
> +          clEnumValN(PF_Text, "text", "Text encoding"),
> ----------------
> This description has two items that claim to be the default, is this a
> typo?
>

It is a typo. Thanks for catching it. Fixed at rL334475.


>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D47955
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180611/d265dc84/attachment.html>