[PATCH] D48055: [DWARFv5] llvm-mc -dwarf-version does not imply -g.

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 11 17:56:34 PDT 2018


aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

So llvm-mc performs a literal translation by default and with -g it generates debug info for the assembler input? Seems reasonable.



================
Comment at: llvm/lib/MC/MCDwarf.cpp:392
+  // Try not to emit an empty compilation directory.
+  const StringRef *CompDir =
+      CompilationDir.empty() ? &CtxCompilationDir : &CompilationDir;
----------------
Could this be a `const StringRef &`?


Repository:
  rL LLVM

https://reviews.llvm.org/D48055





More information about the llvm-commits mailing list