[PATCH] D47831: [DAGCombiner] Recognize more patterns for ABS

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: lib/Target/ARM/ARMInstrNEON.td:5399
+def : Pat<(v2i64 (abs (sub (zext (v2i32 DPR:$opA)), (zext (v2i32 DPR:$opB))))),
+          (VABDLuv2i64 DPR:$opA, DPR:$opB)>;
+
----------------
RKSimon wrote:
> kparzysz wrote:
> > RKSimon wrote:
> > > Is there existing test coverage for these?
> > test/CodeGen/ARM/neon_vabs.ll failed without those.  I think the patterns above it will no longer be triggered actually, but I didn't want to remove them.
> @jmolloy @rengolin Any thoughts?
The new patterns look fine; please delete the old patterns.


Repository:
  rL LLVM

https://reviews.llvm.org/D47831