[PATCH] D48009: [DWARF/AccelTable] Remove getDIESectionOffset for DWARF v5 entries
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 11 15:35:09 PDT 2018
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Seems good to me
================
Comment at: lib/DebugInfo/DWARF/DWARFVerifier.cpp:1267
+ if (none_of(NI.equal_range(Name),
+ [DieUnitOffset](const DWARFDebugNames::Entry &E) {
+ return E.getDIEUnitOffset() == DieUnitOffset;
----------------
Generally I'd suggest just using [&] (capture all by reference) when using a lambda that doesn't escape its scope - as it doesn't tend to add a lot of value to enumerate the specific variables used within a lambda (in the same way that other local scopes in C++ (if/while/for/etc) don't enumerate which variables will be used within them)
Repository:
rL LLVM
https://reviews.llvm.org/D48009
More information about the llvm-commits
mailing list