[PATCH] D47969: [Verifier] Check that ValueAsMetadata belongs to the module
Vlad Tsyrklevich via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 11 12:49:04 PDT 2018
vlad.tsyrklevich added subscribers: tejohnson, pcc.
vlad.tsyrklevich added a comment.
Actually, I'm not sure that mail is necessary. After looking at ODR type uniquing a bit I think the correct behavior is to wrap your check in `if (!M.getContext().isODRUniquingDebugTypes())` since I believe we expect ODR uniquing to be able to create cross-module references but we should otherwise not see them. Adding @tejohnson @pcc to take a look as well.
Repository:
rL LLVM
https://reviews.llvm.org/D47969
More information about the llvm-commits
mailing list