[PATCH] D47998: [Darwin] Use errorHandler from liblldCommon

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 11 12:29:34 PDT 2018


smeenai resigned from this revision.
smeenai added a comment.

Makes sense to me, but I want @ruiu to look over it.



================
Comment at: lib/Driver/DarwinLdDriver.cpp:327
+    error("missing arg value for '" +
+          Twine(parsedArgs.getArgString(missingIndex)) + "' expected " +
+          Twine(missingCount) + " argument(s).");
----------------
Do you need the explicit Twine constructor calls?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D47998





More information about the llvm-commits mailing list