[PATCH] D47491: Expand constrained FP operations

[Cameron McInally via Phabricator via llvm-commits]

cameron.mcinally added a comment.

Thanks, guys.

I'd also like to point out that this Diff will slightly clobber Ulrich's https://reviews.llvm.org/D45576. But, I suspect that it will be a small change to accommodate the difference.



================
Comment at: test/CodeGen/X86/vector-constrained-fp-intrinsics.ll:5
+; CHECK-LABEL: constrained_vector_pow
+; COMMON: pow
+define <2 x double> @constrained_vector_pow() {
----------------
andrew.w.kaylor wrote:
> I think this check needs to do more than this. You should be verifying the complete expansion.
> 
> Also, can you add checks for some other instructions. Some of these won't require expansion, right?
> I think this check needs to do more than this. You should be verifying the complete expansion.

Thanks. I've added a check for the upper POW.

> Also, can you add checks for some other instructions. Some of these won't require expansion, right?

POW is the only strict operation that I've found that currently needs expansion on X86. That said, I have a full set of tests that cover each strict operation. I could add them if you'd like, but it's a bit superfluous for this change. I do intend to add the full set once other patches are sent upstream. Thought?


Repository:
  rL LLVM

https://reviews.llvm.org/D47491