[PATCH] D47947: [mips] Support shrink-wrapping

[Simon Dardis via Phabricator via llvm-commits]

sdardis added inline comments.


================
Comment at: test/CodeGen/Mips/shrink-wrapping.ll:1
+; RUN: llc -march=mips -enable-shrink-wrap=true < %s | \
+; RUN:   FileCheck %s -check-prefixes=SHRINK-WRAP,ALL
----------------
Can you use the update_llc_checks.py script to generate the check lines? You'll need to supply a triple instead of -march=


================
Comment at: test/CodeGen/Mips/shrink-wrapping.ll:7
+
+define dso_local i32 @foo(i32 signext %a) local_unnamed_addr nounwind {
+entry:
----------------
Remove the dso_local, local_unamed_addr and nounwind from this.


================
Comment at: test/CodeGen/Mips/shrink-wrapping.ll:33
+}
+
+declare dso_local void @foo2(i32 signext) local_unnamed_addr
----------------
Can you also provide a test case similar to gcc PR86069? For O32 this consists of a branch over a section of code  to an early return and the branch has to be expanded into a long jump sequence. You can use .space to create arbitrary size chunks of nops. 


================
Comment at: test/CodeGen/Mips/shrink-wrapping.ll:34
+
+declare dso_local void @foo2(i32 signext) local_unnamed_addr
----------------
Similarly here for the dso_local.


Repository:
  rL LLVM

https://reviews.llvm.org/D47947