[PATCH] D48020: [llvm-exegesis] Cleaner design without mutable data.

[Clement Courbet via Phabricator via llvm-commits]

courbet added a comment.

unit tests ?



================
Comment at: tools/llvm-exegesis/lib/Latency.cpp:72
       Conf.Info = "explicit self cycles, selecting one aliasing Conf.";
-      setRandomAliasing(SelfAliasing);
+      setRandomAliasing(SelfAliasing, II, II);
     } else {
----------------
let's add a tiny comment there as this triggers my weirdness detector.


================
Comment at: tools/llvm-exegesis/lib/MCInstrDescView.h:147
 
 // Picks a random configuration, then select a random def and a random use from
+// it and finally set the selected values in the provided InstructionInstances.
----------------
selects


Repository:
  rL LLVM

https://reviews.llvm.org/D48020