Kind request for suggestion about build error

[Pavel Labath via llvm-commits]

[adding back llvm-commits so people know the issue has been resolved]

Hello Mauro,

That's good to hear. I'm glad we were able to resolve this. I still
don't fully understand why does this cause only problems for your
build setup, but explicitly qualifying the open call is more correct
anyway.

On Mon, 11 Jun 2018 at 14:10, Mauro Rossi <issor.oruam at gmail.com> wrote:
>
> Hi Pavel,
> thanks for your response
>
> 2018-06-11 10:20 GMT+02:00 Pavel Labath <labath at google.com>:
> > Hi Mauro,
> >
> > it would be great to know what is the reason that template deduction
> > fails here. Is that the full error message you pasted above? I would
> > expect some explanatory notes to explain why the template argument
> > could not be inferred. If the compiler does not provide that, could
> > you manually check what definition(s) of open are in scope for that
> > particular line. I'm pretty sure this error can be fixed by tweaking
> > the source code a bit, but it's hard to say how without more details
> > (as a wild guess, you can try replacing "open" with "::open" on that
> > line).
>
> Replacing open with ::open the build is completed, thanks a lot!
>
> Should the 'read' also be changed at line 219, from formal point of view,
> like it is ::read at line 476?
>
> Line 219    ReadBytes = sys::RetryAfterSignal(-1, read, FD, Buffer.end(), ChunkSize);
>
> Line 476    ssize_t NumRead = sys::RetryAfterSignal(-1, ::read, FD, BufPtr, BytesLeft);
>
>
> >
> > Also, is there anything special about your build setup? What standard
> > library are you using? It's kinda surprising that you're running into
> > this now, although that particular patch has been there for almost a
> > year now...
>
> The build system is basically standard Android Build System toolchain with clang (C++11)
>
> utente at utente-MS-7576:~/oreo-x86_kernel/external/llvm70$ mgrep c++11
> ./llvm-device-build.mk:62: -std=c++11
> ./llvm-host-build.mk:57: -std=c++11
>
> The problem started happening when the first people started building llvm50,  llvm60 with Android
> (nougat-x86 and oreo-x86) to test amdgpu/AMD DC with kernel 4.15 an later,
> so around October, 2017 but the issue is there since June, 5th 2017 as you said.
>
> Are you going to commit the changes in llvm 7.0.0 master?
> Kind regards
>
> Mauro

Yes, I can do that shortly.

cheers,
pavel