[PATCH] D48018: AMDGPU: Convert test cases to the dimension-aware intrinsics

Mon Jun 11 05:51:14 PDT 2018

nhaehnle created this revision.
nhaehnle added reviewers: arsenm, rampitec.
Herald added subscribers: javed.absar, t-tye, tpr, dstuttard, yaxunl, wdng, kzhuravl, qcolombet, MatzeB.

Also explicitly port over some tests in llvm.amdgcn.image.* that were
missing. Some tests are removed because they no longer apply (i.e.
explicitly testing building an address vector via insertelement).

This is in preparation for the eventual removal of the old-style
intrinsics.

Some additional notes:

- constant-address-space-32bit.ll: change some GCN-NEXT to GCN because the instruction schedule was subtly altered
- insert_vector_elt.ll: the old test didn't actually test anything, because %tmp1 was not used; remove the load, because it doesn't work (Because of the amdgpu_ps calling convention? In any case, it's orthogonal to what the test claims to be testing.)

Change-Id: Idfa99b6512ad139e755e82b8b89548ab08f0afcf

Repository:
  rL LLVM

https://reviews.llvm.org/D48018

Files:
  test/Analysis/DivergenceAnalysis/AMDGPU/llvm.amdgcn.image.atomic.ll
  test/CodeGen/AMDGPU/adjust-writemask-invalid-copy.ll
  test/CodeGen/AMDGPU/commute-shifts.ll
  test/CodeGen/AMDGPU/constant-address-space-32bit.ll
  test/CodeGen/AMDGPU/else.ll
  test/CodeGen/AMDGPU/image-schedule.ll
  test/CodeGen/AMDGPU/insert_vector_elt.ll
  test/CodeGen/AMDGPU/llvm.amdgcn.image.atomic.dim.ll
  test/CodeGen/AMDGPU/llvm.amdgcn.image.dim.ll
  test/CodeGen/AMDGPU/llvm.amdgcn.image.gather4.dim.ll
  test/CodeGen/AMDGPU/llvm.amdgcn.image.gather4.o.dim.ll
  test/CodeGen/AMDGPU/llvm.amdgcn.image.sample.dim.ll
  test/CodeGen/AMDGPU/llvm.amdgcn.image.sample.o.dim.ll
  test/CodeGen/AMDGPU/llvm.amdgcn.ps.live.ll
  test/CodeGen/AMDGPU/llvm.amdgcn.s.waitcnt.ll
  test/CodeGen/AMDGPU/print-mir-custom-pseudo.ll
  test/CodeGen/AMDGPU/sgpr-copy.ll
  test/CodeGen/AMDGPU/si-scheduler.ll
  test/CodeGen/AMDGPU/si-sgpr-spill.ll
  test/CodeGen/AMDGPU/skip-if-dead.ll
  test/CodeGen/AMDGPU/split-smrd.ll
  test/CodeGen/AMDGPU/subreg-coalescer-crash.ll
  test/CodeGen/AMDGPU/undefined-subreg-liverange.ll
  test/CodeGen/AMDGPU/unigine-liveness-crash.ll
  test/CodeGen/AMDGPU/wqm.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48018.150728.patch
Type: text/x-patch
Size: 140003 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180611/0ff8aa89/attachment-0001.bin>