[PATCH] D48001: [Utils] update_llc_test_checks.py: support AMDGPU backend: AMDGCN, r600 triples

Mon Jun 11 01:00:40 PDT 2018

lebedev.ri created this revision.
lebedev.ri added reviewers: spatel, RKSimon, MaskRay, tstellar.
lebedev.ri added a project: AMDGPU.
Herald added subscribers: t-tye, tpr, dstuttard, yaxunl, wdng, kzhuravl.

Lack of that support has taken me by surprise.
I need to add (or at least look at) some tests for https://reviews.llvm.org/D47980#1127615,
and i don't really fancy doing that by hand.

The asm pattern is quite similar to that of x86:
https://godbolt.org/g/kBDB85
just with `#` replaced with `;`


Repository:
  rL LLVM

https://reviews.llvm.org/D48001

Files:
  utils/UpdateTestChecks/asm.py


Index: utils/UpdateTestChecks/asm.py
===================================================================

--- utils/UpdateTestChecks/asm.py
+++ utils/UpdateTestChecks/asm.py
@@ -34,6 +34,13 @@
      r'.Lfunc_end[0-9]+:\n',
      flags=(re.M | re.S))
 
+ASM_FUNCTION_AMDGPU_RE = re.compile(
+    r'^_?(?P<func>[^:]+):[ \t]*;+[ \t]*@(?P=func)\n[^:]*?'
+    r'(?P<body>.*?)\n' # (body of the function)
+    # This list is incomplete
+    r'.Lfunc_end[0-9]+:\n',
+    flags=(re.M | re.S))
+
 ASM_FUNCTION_MIPS_RE = re.compile(
     r'^_?(?P<func>[^:]+):[ \t]*#+[ \t]*@(?P=func)\n[^:]*?' # f: (name of func)
     r'(?:^[ \t]+\.(frame|f?mask|set).*?\n)+'  # Mips+LLVM standard asm prologue
@@ -116,6 +123,16 @@
   asm = common.SCRUB_TRAILING_WHITESPACE_RE.sub(r'', asm)
   return asm
 
+def scrub_asm_amdgpu(asm, args):
+  # Scrub runs of whitespace out of the assembly, but leave the leading
+  # whitespace in place.
+  asm = common.SCRUB_WHITESPACE_RE.sub(r' ', asm)
+  # Expand the tabs used for indentation.
+  asm = string.expandtabs(asm, 2)
+  # Strip trailing whitespace.
+  asm = common.SCRUB_TRAILING_WHITESPACE_RE.sub(r'', asm)
+  return asm
+
 def scrub_asm_arm_eabi(asm, args):
   # Scrub runs of whitespace out of the assembly, but leave the leading
   # whitespace in place.
@@ -188,6 +205,8 @@
       'x86': (scrub_asm_x86, ASM_FUNCTION_X86_RE),
       'i386': (scrub_asm_x86, ASM_FUNCTION_X86_RE),
       'aarch64': (scrub_asm_arm_eabi, ASM_FUNCTION_AARCH64_RE),
+      'r600': (scrub_asm_amdgpu, ASM_FUNCTION_AMDGPU_RE),
+      'amdgcn': (scrub_asm_amdgpu, ASM_FUNCTION_AMDGPU_RE),
       'arm-eabi': (scrub_asm_arm_eabi, ASM_FUNCTION_ARM_RE),
       'thumb-eabi': (scrub_asm_arm_eabi, ASM_FUNCTION_ARM_RE),
       'thumbv6': (scrub_asm_arm_eabi, ASM_FUNCTION_ARM_RE),


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48001.150684.patch
Type: text/x-patch
Size: 1780 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180611/a339ed31/attachment-0001.bin>
