[llvm] r334379 - [TableGen] Combine two constructors by taking vectors by value instead of trying to support combininations for rvalue and lvalue references.

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 10 16:15:48 PDT 2018


Author: ctopper
Date: Sun Jun 10 16:15:48 2018
New Revision: 334379

URL: http://llvm.org/viewvc/llvm-project?rev=334379&view=rev
Log:
[TableGen] Combine two constructors by taking vectors by value instead of trying to support combininations for rvalue and lvalue references.

Modified:
    llvm/trunk/utils/TableGen/CodeGenDAGPatterns.h

Modified: llvm/trunk/utils/TableGen/CodeGenDAGPatterns.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/CodeGenDAGPatterns.h?rev=334379&r1=334378&r2=334379&view=diff
==============================================================================
--- llvm/trunk/utils/TableGen/CodeGenDAGPatterns.h (original)
+++ llvm/trunk/utils/TableGen/CodeGenDAGPatterns.h Sun Jun 10 16:15:48 2018
@@ -998,20 +998,12 @@ public:
 /// processed to produce isel.
 class PatternToMatch {
 public:
-  PatternToMatch(Record *srcrecord, const std::vector<Predicate> &preds,
+  PatternToMatch(Record *srcrecord, std::vector<Predicate> preds,
                  TreePatternNodePtr src, TreePatternNodePtr dst,
-                 const std::vector<Record *> &dstregs, int complexity,
+                 std::vector<Record *> dstregs, int complexity,
                  unsigned uid, unsigned setmode = 0)
       : SrcRecord(srcrecord), SrcPattern(src), DstPattern(dst),
-        Predicates(preds), Dstregs(std::move(dstregs)),
-        AddedComplexity(complexity), ID(uid), ForceMode(setmode) {}
-
-  PatternToMatch(Record *srcrecord, std::vector<Predicate> &&preds,
-                 TreePatternNodePtr src, TreePatternNodePtr dst,
-                 std::vector<Record *> &&dstregs, int complexity, unsigned uid,
-                 unsigned setmode = 0)
-      : SrcRecord(srcrecord), SrcPattern(src), DstPattern(dst),
-        Predicates(preds), Dstregs(std::move(dstregs)),
+        Predicates(std::move(preds)), Dstregs(std::move(dstregs)),
         AddedComplexity(complexity), ID(uid), ForceMode(setmode) {}
 
   Record          *SrcRecord;   // Originating Record for the pattern.




More information about the llvm-commits mailing list