[debuginfo-tests] r334369 - [debuginfo-tests] Always use the system python to invoke llgdb.py.

[Ahmed Bougacha via llvm-commits]

Author: ab
Date: Sun Jun 10 12:38:26 2018
New Revision: 334369

URL: http://llvm.org/viewvc/llvm-project?rev=334369&view=rev
Log:
[debuginfo-tests] Always use the system python to invoke llgdb.py.

/usr/bin/env is recommended as a cross-platform way to find python. But:
- we're only using lldb on darwin, where we know python (or at least,
  the xcrun-style shortcut) is in /usr/bin/
- the python interpreter in LLDB comes from /S/L/F:
  $ otool -L Contents/SharedFrameworks/LLDB.framework/LLDB | grep Python
   /System/Library/Frameworks/Python.framework/Versions/2.7/Python

so when we use the lldb python module, it calls into the swig/python
support in the lldb framework, and if there's a mismatch between the
interpreter and the linked python, weird things occur.

In theory, I believe this should be done by:
- looking for the LLDB framework (llgdb.py does some of that)
- finding the binary inside the framework
- looking for the Python it was linked against (otool -L)
- finding the interpreter executable inside the Python.framework

But in practice, that's only different if we use a custom LLDB
framework/pythonpath when running these tests, and AFAIK nobody does
that right now, so the code would be dead anyway.

Don't pretend we can use any arbitrary python: just use the system one.

Differential Revision: https://reviews.llvm.org/D47967

Modified:
    debuginfo-tests/trunk/test_debuginfo.pl

Modified: debuginfo-tests/trunk/test_debuginfo.pl
URL: http://llvm.org/viewvc/llvm-project/debuginfo-tests/trunk/test_debuginfo.pl?rev=334369&r1=334368&r2=334369&view=diff
==============================================================================
--- debuginfo-tests/trunk/test_debuginfo.pl (original)
+++ debuginfo-tests/trunk/test_debuginfo.pl Sun Jun 10 12:38:26 2018
@@ -56,7 +56,8 @@ my $my_debugger = $ENV{'DEBUGGER'};
 if (!$my_debugger) {
     if ($use_lldb) {
         my $path = dirname(Cwd::abs_path($0));
-        $my_debugger = "/usr/bin/env python $path/llgdb.py";
+        # At least on darwin, LLDB needs te system python.
+        $my_debugger = "/usr/bin/python $path/llgdb.py";
     } else {
         $my_debugger = "gdb";
     }