[PATCH] D47977: [Fuzzer] First step to thread affinity

David CARLIER via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 9 03:12:40 PDT 2018


devnexen added a comment.

In https://reviews.llvm.org/D47977#1127238, @dvyukov wrote:

> > I understand your points, but usually see the jobs are often bound to cpu0 while this cpu can be potentially pretty busy.
>
> Whoever is doing this needs to be fixed.
>  It's exactly this kind of code that introduces such problems. It tries to be "smart" but does not have full picture. And we are adding more such code, so we will have more such problems. If one uses rand mode and 2 threads happens to be bound to the same core, we lose half of performance. The sequential mode occupies cores sequentially, so two independent processes will oversubscribe first half of cores and leave remaining cores idle.
>  If you are adding these flags to some scripts, you can just use taskset there.


True ideally what I tried to say in the description is ideally the cpu load ought to be checked first but that s a lot of code :-)


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D47977





More information about the llvm-commits mailing list