[PATCH] D47441: SafepointIRVerifier should ignore dead blocks and dead edges

Artur Pilipenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 9 02:30:55 PDT 2018


apilipenko added a comment.

Can you describe what is the difference you observe in the verifier behavior with and without simplifications before? There will always be cases when some simplifications before the verifier change the CFG. You won't be able to handle everything in this analysis.



================
Comment at: lib/IR/CFGDeadness.cpp:115-116
+  for (const BasicBlock *BB : RPOT)
+    for (auto &BI : *BB)
+      processInstruction(&BI);
+}
----------------
You only look at branches in processInstruction, right? You don't need to iterate all instructions then, just check the terminator of the BB.  


https://reviews.llvm.org/D47441





More information about the llvm-commits mailing list