[PATCH] D47967: [debuginfo-tests] Always use the system python to invoke llgdb.py.

Ahmed Bougacha via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 8 18:36:39 PDT 2018


ab added a comment.

Precisely:  `/usr/bin/env` is recommended as a cross-platform way to find python.  But:

- we're only using lldb on darwin, where we know python (or at least, the xcrun-style shortcut) is in `/usr/bin/`
- the python interpreter in LLDB comes from /S/L/F, for instance:



          $ otool -L /Applications/Xcode.app/Contents/SharedFrameworks/LLDB.framework/LLDB | grep Python
  	    /System/Library/Frameworks/Python.framework/Versions/2.7/Python (compatibility version 2.7.0, current version 2.7.10)

so when we use the lldb python module, it calls into the swig/python support in the lldb framework, and if there's a mismatch between the interpreter and the linked python, weird things occur.

In theory, this should be done by:

- looking for the LLDB framework (llgdb.py does some of that)
- finding the binary inside the framework
- looking for the Python it was linked against (otool -L)
- finding the interpreter executable inside the Python.framework

But in practice, that's only different if we use a custom LLDB framework/pythonpath when running these tests, and AFAIK nobody does that right now, so the code would be dead anyway.


https://reviews.llvm.org/D47967





More information about the llvm-commits mailing list