[PATCH] D44620: [XRay][profiler] Part 4: Profiler Mode Wiring

Keith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 8 18:16:25 PDT 2018


kpw added a comment.

I'm going to have to download the renamed files to diff locally. Is there a way to do this in Differential that I'm missing?



================
Comment at: compiler-rt/test/xray/TestCases/Posix/profiling-multi-threaded.cc:8
+//
+// UNSUPPORTED: target-is-mips64,target-is-mips64el
+
----------------
dberris wrote:
> kpw wrote:
> > Do you need a thing to exclude windows since you're calling readtsc()
> Good point. Yes, need to require Linux for now.
I think this still must be done before you submit.


https://reviews.llvm.org/D44620





More information about the llvm-commits mailing list