[PATCH] D47874: [SCEVExpander] Ignore dbg info when finding insertion point.

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 8 15:34:57 PDT 2018


davide added a comment.

In https://reviews.llvm.org/D47874#1126902, @fhahn wrote:

> Or maybe it would be even more convenient to just have a new iterator type, which skips such meta instructions.


The reason I don't necessarily want to go that route is that people now have to think about which iterator they should use when walking instructions in a BB.
I think it creates more confusion than it helps. Your other idea is fine to me, but I'd love to hear from others (Eli/Vedant/Adrian etc.)


https://reviews.llvm.org/D47874





More information about the llvm-commits mailing list