[PATCH] D47919: llvm-readobj: add experimental support for SHT_RELR sections.

[Rahul Chaudhry via Phabricator via llvm-commits]

rahulchaudhry added inline comments.


================
Comment at: tools/llvm-readobj/ELFDumper.cpp:2637
   Fields[0].Str = Offset;
-  Fields[1].Str = Info;
-  Fields[2].Str = RelocName;
-  Fields[3].Str = Value;
-  Fields[4].Str = TargetName;
+  if (!IsRelr) {
+    Fields[1].Str = Info;
----------------
Fields[1-4] are empty for SHT_RELR section, but they were already assigned a width above.
Doing it this way results in trailing spaces on every line. Does it matter?



================
Comment at: tools/llvm-readobj/ELFDumper.cpp:3304
   Fields[0].Str = Offset;
-  Fields[1].Str = Info;
-  Fields[2].Str = RelocName.c_str();
-  Fields[3].Str = Value;
-  Fields[4].Str = SymbolName;
+  if (!IsRelr) {
+    Fields[1].Str = Info;
----------------
Same as above, this results in trailing spaces on every line.


Repository:
  rL LLVM

https://reviews.llvm.org/D47919