[PATCH] D47568: [Power9] Do the add-imm peephole for pseudo instruction DFLOADf32/DFLOADf64 and the store pair

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 8 15:14:12 PDT 2018


nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.

Other than the minor nit, LGTM.



================
Comment at: llvm/test/CodeGen/PowerPC/toc-float.ll:65
+
+; TODO - We could do some peephole post RA to optimize it as LFD
+; CHECK-LABEL: doubleLargeConstantArray
----------------
This comment is unclear to me. I'm not sure how we could use a D-Form instruction when the offset doesn't fit in the displacement field. In any case, clarify the comment or remove it.


https://reviews.llvm.org/D47568





More information about the llvm-commits mailing list