[PATCH] D47587: [RISCV] Codegen support for atomic operations on RV32I

James Y Knight via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 8 10:34:53 PDT 2018


jyknight accepted this revision.
jyknight added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/Target/RISCV/RISCVInstrInfo.td:756
+// fence acq_rel -> fence.tso
+def : Pat<(atomic_fence (i32 6), (imm)), (FENCE_TSO)>;
+// fence seq_cst -> fence rw, rw
----------------
Did you miss uploading the part of the change to add a definition of FENCE_TSO? I don't see where that's defined here.

But marking LGTM anyways, assuming that'll get fixed before commit.


https://reviews.llvm.org/D47587





More information about the llvm-commits mailing list