[PATCH] D47949: [callsitesplit] Limit the # of predecessors walk when recording condition

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 8 09:51:51 PDT 2018


davide added a comment.

In https://reviews.llvm.org/D47949#1126627, @fhahn wrote:

> The pass currently walks back the single predecessors of a call site and records conditions relevant to the call site. There are cases where doing so we end up visiting the same blocks over and over again. It would probably be better to do a single traversal of the CFG and record relevant conditions once. I have to think a bit more about it, but maybe PredicateInfo could be helpful here and allow us to avoid visiting predecessors.


Yes, that could be one solution. In general, I don't think that we should visit a block more than a constant amount of time to split the callsites.


Repository:
  rL LLVM

https://reviews.llvm.org/D47949





More information about the llvm-commits mailing list