[PATCH] D46545: [sanitizer] Move fgets, fputs and puts into sanitizer_common

[Kamil Rytarowski via Phabricator via llvm-commits]

krytarowski added a subscriber: tomsun.0.7.
krytarowski added a comment.

In https://reviews.llvm.org/D46545#1126617, @Lekensteyn wrote:

> In https://reviews.llvm.org/D46545#1126599, @krytarowski wrote:
>
> > We are now requiring this on NetBSD for MSanitized userland. Some programs break without puts(3) / fputs(3) interceptors there.
>
>
> Is there a link/discussion to this issue? (f)puts just read from a buffer, how would lack of interceptors cause MSan to break?
>  I found https://github.com/google/sanitizers/issues/955, but it does not directly mention such an issue.
>
> (This change is still on my TODO list.)


https://github.com/google/sanitizers/issues/955 context "libfuzzer integration with the NetBSD userland #955"

There are so many issues with local utilities that we don't bother with reporting them.. as we need to fix them on our own.

https://github.com/plusun/compiler-rt/commit/bbcbdbd2d6714c6d2e4436b17e694c355670e58c our fix for this issue "Add interceptors for puts and fputs, remove old ones"

If I remember correctly, it puts(3)/fputs(3) was breaking GNU groff in the LLVM style of NetBSD distribution. (CC: @tomsun.0.7 -- the author)


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D46545