[PATCH] D47711: [AArch64][SVE] Asm: Add parsing/printing support for exact FP immediates.

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 8 05:59:00 PDT 2018


SjoerdMeijer added a comment.

Thanks, this looks a lot better IMO.



================
Comment at: lib/Target/AArch64/AArch64SystemOperands.td:249
+
+def : ExactFPImm<"zero", "0.0", 0x0>;
+def : ExactFPImm<"half", "0.5", 0x1>;
----------------
The only thing I am wondering is if we can easily get rid of this of these "half", "one", etc., definitions?  This still feels a bit like a few special cases, a bit hacky if you like,  that can perhaps be made a bit more generic. I don't have a suggestion yet how though; I would need to spend some more time  looking at it.


https://reviews.llvm.org/D47711





More information about the llvm-commits mailing list