[PATCH] D31287: [mips] Fix atomic compare and swap at O0, v3
Alex Bradbury via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 8 05:32:29 PDT 2018
asb added inline comments.
================
Comment at: lib/Target/Mips/MipsTargetMachine.cpp:288-290
+void MipsPassConfig::addPreSched2() {
+ addPass(createMipsExpandPseudoPass());
+}
----------------
Would it be more robust to have this pass under addPreEmit2? This guarantees it runs after potentially troublesome passes such as the machineoutliner (obviously not yet enabled for Mips anyway), and you'd no longer need to worry about machine block placement.
Repository:
rL LLVM
https://reviews.llvm.org/D31287
More information about the llvm-commits
mailing list