[PATCH] D47793: [MSan] Report proper error on allocator failures instead of CHECK(0)-ing

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 7 16:50:55 PDT 2018


vitalybuka added inline comments.


================
Comment at: test/msan/Posix/lit.local.cfg:8
+
+if root.host_os in ['Windows']:
+  config.unsupported = True
----------------
alekseyshl wrote:
> vitalybuka wrote:
> > we don't have msan on windows?
> > I guess it's always posix
> No, we do not. But I'd rather have the same config in all sanitizers, easier to maintain, don't you agree?
They are very different and independent so I am not sure how exactly this simplify maintains.
However now for each tests we will have need to decide if this is Posix test or common test, when in fact there is not difference.
Lets keep it without Posix dir until we rely need it.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D47793





More information about the llvm-commits mailing list