[PATCH] D47914: [lldb-mi] Add overloaded method for setting an error.
Alexander Polyakov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 7 16:08:15 PDT 2018
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334245: [lldb-mi] Add overloaded method for setting an error. (authored by apolyakov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D47914?vs=150421&id=150428#toc
Repository:
rL LLVM
https://reviews.llvm.org/D47914
Files:
lldb/trunk/tools/lldb-mi/MICmdBase.cpp
lldb/trunk/tools/lldb-mi/MICmdBase.h
Index: lldb/trunk/tools/lldb-mi/MICmdBase.cpp
===================================================================
--- lldb/trunk/tools/lldb-mi/MICmdBase.cpp
+++ lldb/trunk/tools/lldb-mi/MICmdBase.cpp
@@ -214,6 +214,23 @@
//++
//------------------------------------------------------------------------------------
+// Details: Short cut function to enter error information into the command's
+// metadata object and set the command's error status.
+// Type: Method.
+// Args: error - (R) Command result description.
+// Return: None.
+// Throws: None.
+//--
+void CMICmdBase::SetError(const lldb::SBError &error) {
+ const char *error_cstr = error.GetCString();
+ if (error_cstr)
+ SetError(error_cstr);
+ else
+ SetError("unknown error");
+}
+
+//++
+//------------------------------------------------------------------------------------
// Details: Ask a command to provide its unique identifier.
// Type: Method.
// Args: A unique identifier for this command class.
Index: lldb/trunk/tools/lldb-mi/MICmdBase.h
===================================================================
--- lldb/trunk/tools/lldb-mi/MICmdBase.h
+++ lldb/trunk/tools/lldb-mi/MICmdBase.h
@@ -12,6 +12,8 @@
// C Includes
// C++ Includes
// Other libraries and framework includes
+#include "lldb/API/SBError.h"
+
// Project includes
#include "MICmdArgSet.h"
#include "MICmdData.h"
@@ -80,6 +82,7 @@
// Methods:
protected:
void SetError(const CMIUtilString &rErrMsg);
+ void SetError(const lldb::SBError &error);
template <class T> T *GetOption(const CMIUtilString &vStrOptionName);
bool ParseValidateCmdOptions();
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D47914.150428.patch
Type: text/x-patch
Size: 1647 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180607/c4905e46/attachment.bin>
More information about the llvm-commits
mailing list