[PATCH] D47666: Refactored clang-fuzzer and added new (copy) files

Kostya Serebryany via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 7 15:08:37 PDT 2018


kcc added a comment.

Some feedback on the generated code:

  while (1){

let's not have the while loops inside the for loops for now. 
If the initial goal is to stress the loop optimizations (e.g. vectorizer), 
loops likes this are just a distraction

  for (int loop_ctr = 0

too verbose. Use 'i'm 'j', 'k'
also, alternate int, unsigned, size_t, long (later).

  a[436863498 % s]=1;

this is good for keeping the code UB-free, but it will render the tests non-vectorizable. 
need more tests that won't use `% s`

  void foo(int *a, size_t s) {

ok for a starter, but will need a more rich signature in the future versions.


Repository:
  rL LLVM

https://reviews.llvm.org/D47666





More information about the llvm-commits mailing list