[PATCH] D47595: [VPlan] Move recipe construction to VPRecipeBuilder.

Diego Caballero via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 7 14:33:30 PDT 2018


dcaballe added a comment.

In https://reviews.llvm.org/D47595#1123827, @fhahn wrote:

> In https://reviews.llvm.org/D47595#1119195, @dcaballe wrote:
>
> > Thanks, Florian! LGTM!
> >  Please wait until we finish the other two related reviews to commit it, in case we have to change something else.
>
>
> As I updated https://reviews.llvm.org/D46827 to not rely on VPRecipeBuilder, but instead create a limited subset of recipes directly, do you think this is good to go?


Yes, this refactoring still makes sense. OK, go ahead and commit it!


https://reviews.llvm.org/D47595





More information about the llvm-commits mailing list