[PATCH] D47890: [Polly][zorg] Enable GPGPU Codegen on the builders only if NVPTX is an LLVM target

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added inline comments.


================
Comment at: zorg/buildbot/builders/PollyBuilder.py:78-79
                     "-DCMAKE_BUILD_TYPE=Release"] + cmake_install + extraCmakeArgs
+    hasNVPTX = any(True for A in reversed(extraCmakeArgs)
+                   if 'LLVM_TARGETS_TO_BUILD' in A and 'NVPTX' in A)
+    if hasNVPTX:
----------------
[suggestion] `any('LLVM_TARGETS_TO_BUILD' in A and 'NVPTX' in A for A in extraCmakeArgs)`

Does this actually work? Isn't `extraCmakeArgs` formatted like `['-DLLVM_TARGETS_TO_BUILD=X86;NVPTX']`, that is, neither 'LLVM_TARGETS_TO_BUILD' nor 'NVPTX' as entire strings are in the list.


================
Comment at: zorg/buildbot/builders/PollyBuilder.py:80-81
+                   if 'LLVM_TARGETS_TO_BUILD' in A and 'NVPTX' in A)
+    if hasNVPTX:
+        cmakeCommand.append("-DPOLLY_ENABLE_GPGPU_CODEGEN=ON")
+
----------------
Could you add a comment why this is here?


https://reviews.llvm.org/D47890