[PATCH] D47811: [PATCH] [DWARF] Kotlin language

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

It would be nice to also add a testcase that compiles an otherwise empty llvm IR file with a DICompileUnit with Kotlin as the implementation language and pipes the output to llvm-dwarfdump and verifies that it comes out correctly.



================
Comment at: include/llvm/BinaryFormat/Dwarf.def:665
 HANDLE_DW_LANG(0x0025, BLISS, 5, DWARF)
+HANDLE_DW_LANG(0x0026, Kotlin, 5, DWARF)
 // Vendor extensions:
----------------
aprantl wrote:
> I think this should be "6", not "5"?
Could you please also add a 
`// Tentative DWARF v.6 definitions.`
comment above to drive home the point that these are subject to change?

thanks!


Repository:
  rL LLVM

https://reviews.llvm.org/D47811