[PATCH] D47706: Add a factory method to ConstantDataArray that allows to pass in the data as StringRef
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 7 12:00:26 PDT 2018
efriedma added a comment.
Oh, you're translating from your Constant abstraction to LLVM's Constant abstraction. Makes sense.
Please rename this to getRaw or something, so it's clear it's not type-safe. And please fix the doc comment to specify what element types are allowed, and note how it deals with endianness.
Repository:
rL LLVM
https://reviews.llvm.org/D47706
More information about the llvm-commits
mailing list