[PATCH] D47491: Expand constrained FP operations

[Andy Kaylor via Phabricator via llvm-commits]

andrew.w.kaylor added a comment.

I'm adding Craig Topper as a reviewer because he knows the vector selection DAG stuff better than I do. The constrained FP handling looks OK to me.



================
Comment at: test/CodeGen/X86/vector-constrained-fp-intrinsics.ll:1
+; RUN: llc -O3 -mtriple=x86_64-pc-linux < %s | FileCheck --check-prefix=COMMON --check-prefix=NO-FMA --check-prefix=FMACALL64 --check-prefix=FMACALL32 %s
+; RUN: llc -O3 -mtriple=x86_64-pc-linux -mattr=+fma < %s | FileCheck -check-prefix=COMMON --check-prefix=HAS-FMA --check-prefix=FMA64 --check-prefix=FMA32 %s
----------------
I'm guessing you copied these run lines from somewhere else. It doesn't look like you need multiple runs or the extra check prefixes.


================
Comment at: test/CodeGen/X86/vector-constrained-fp-intrinsics.ll:5
+; CHECK-LABEL: constrained_vector_pow
+; COMMON: pow
+define <2 x double> @constrained_vector_pow() {
----------------
I think this check needs to do more than this. You should be verifying the complete expansion.

Also, can you add checks for some other instructions. Some of these won't require expansion, right?


https://reviews.llvm.org/D47491