[PATCH] D47831: [DAGCombiner] Recognize more patterns for ABS

Krzysztof Parzyszek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 7 08:54:39 PDT 2018


kparzysz added a comment.

In https://reviews.llvm.org/D47831#1124238, @spatel wrote:

> If we want to keep going with a DAG patch, we'll need codegen tests. A basic x86 example is shown in PR36036.


Codegen tests already exist: test/CodeGen/Hexagon/abs.ll. That testcase used to rely on Hexagon-specific selection patterns, which this patch removes.


Repository:
  rL LLVM

https://reviews.llvm.org/D47831





More information about the llvm-commits mailing list