[PATCH] D47441: SafepointIRVerifier should ignore dead blocks and dead edges

[Anna Thomas via Phabricator via llvm-commits]

anna added inline comments.


================
Comment at: lib/IR/CFGDeadness.cpp:160
+INITIALIZE_PASS_BEGIN(CFGDeadnessWrapperPass, "cfgdeadness",
+                      "CFG Deadness", true, true)
+INITIALIZE_PASS_DEPENDENCY(DominatorTreeWrapperPass)
----------------
yrouban wrote:
> anna wrote:
> > it doesn't modify CFG, so the cfg arg should be false.  
> Hm, it is not obvious from the sources.
> But why DominatorTreeWrapperPass has its set to true then?
>   INITIALIZE_PASS(DominatorTreeWrapperPass, "domtree", "Dominator Tree Construction", true, true)
> 
not sure about the dom tree case - might be a bug, but pretty much all other analysis pass have the CFG arg as false, because, we don't modify the CFG (and I believe that's true in this pass as well, right?). 



https://reviews.llvm.org/D47441