[PATCH] D47346: [X86] Add a new pass to fold extension into load instructions in previous BB

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: lib/Target/X86/X86FoldXBBExtLoad.cpp:1
+//===-- X86FixupBWInsts.cpp - Fixup Byte or Word instructions -----------===//
+//
----------------
Fix filename and brief


================
Comment at: test/CodeGen/X86/fold-xbb-ext-load.ll:8-15
+; CHECK:        movzwl  a, %esi
+; CHECK-NEXT:   calll   v1
+; CHECK-NEXT:   jmp     .LBB0_3
+; CHECK-NEXT: .LBB0_2:
+; CHECK-NEXT:   movzwl  a+2, %esi
+; CHECK-NEXT:   calll   v2
+; CHECK-NEXT: .LBB0_3:
----------------
chandlerc wrote:
> Can you craft yoru test case to be reasonable to read with the automatically generated CHECK lines? That always makes maintenance easier *if* the result is readable... not sure if these will be.
> 
> You might need to break this apart into separate functions to make it read better.
This doesn't look like its auto-generated - can you use update_llc_test_check.py?


https://reviews.llvm.org/D47346