[PATCH] D47790: Expand the file comment for the error handlers.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 6 16:55:52 PDT 2018


pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lld/include/lld/Common/ErrorHandler.h:19
+//   ErrorOr<T> is rejected because otherwise we would have to wrap a large
+//   number of functions in lld with ErorrOr. With that approach, if some
+//   function F can fail, not only F but all functions that transitively
----------------
*ErrorOr


================
Comment at: lld/include/lld/Common/ErrorHandler.h:31
+//   handle is compiled binary, so we don't need that sophisticated error
+//   reporting mechanism as Clang has.
+//
----------------
This would read a little better: "we don't need an error reporting mechanism that's as sophisticated as the one that Clang has".


https://reviews.llvm.org/D47790





More information about the llvm-commits mailing list