[PATCH] D47855: [llvm-objcopy] Remove unused field from Object

Alexander Shaposhnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 6 16:49:46 PDT 2018


alexshap added inline comments.


================
Comment at: Object.h:622
-      : OwnedData(std::move(Data)) {}
-  virtual ~Object() = default;
-
----------------
Object is never deleted polymorphically, it's not even a part of a hierarchy, probably the class itself should be marked final. 


Repository:
  rL LLVM

https://reviews.llvm.org/D47855





More information about the llvm-commits mailing list