[PATCH] D47844: [ThinLTO] Compute GUID directly from GV when building per-module index

[Teresa Johnson via llvm-commits]

On Wed, Jun 6, 2018 at 1:29 PM Teresa Johnson via Phabricator <
reviews at reviews.llvm.org> wrote:

> tejohnson created this revision.
> tejohnson added a reviewer: pcc.
> Herald added a subscriber: inglorion.
>
> I discovered when writing the summary parsing support that the
> per-module index builder and writer are computing the GUID from the
> value name alone (ignoring the linkage type). This was ok since those
> GUID were not emitted in the bitcode, and there are never multiple
> conflicting names in a single module.
>
> However, I don't see a reason for making the GUID computation different
> for the per-module case. It also makes things simpler on the parsing
> side to have the GUID computation.

"to have the GUID computation consistent." (fixed in my git log)


> So this patch changes the summary
> analysis phase and the per-module summary writer to compute the GUID
> using the facility on the GlobalValue.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D47844
>
> Files:
>   include/llvm/IR/ModuleSummaryIndex.h
>   lib/Analysis/ModuleSummaryAnalysis.cpp
>   lib/Bitcode/Writer/BitcodeWriter.cpp
>
>

-- 
Teresa Johnson |  Software Engineer |  tejohnson at google.com |  408-460-2413
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180606/9884912f/attachment.html>