[PATCH] D47841: [asan] Instrument comdat globals on COFF targets

[Reid Kleckner via Phabricator via llvm-commits]

rnk created this revision.
rnk added reviewers: eugenis, vitalybuka.
Herald added a subscriber: hiraditya.

If we can use comdats, then we can make it so that the global metadata
is thrown away if the prevailing definition of the global was
uninstrumented. I have only tested this on COFF targets, but in theory,
there is no reason that we cannot also do this for ELF.

This will allow us to re-enable string merging with ASan on Windows,
reducing the binary size cost of ASan on Windows.


https://reviews.llvm.org/D47841

Files:
  llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp
  llvm/test/Instrumentation/AddressSanitizer/win-string-literal.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D47841.150175.patch
Type: text/x-patch
Size: 5469 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180606/c5fa40d8/attachment.bin>