[PATCH] D47783: [MS][ARM64]: Hoist __ImageBase handling into TargetLoweringObjectFileCOFF::lowerRelativeReference, so that all COFF targets get this.

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

Needs a test. I think you can copy llvm/test/MC/COFF/ir-to-imgrel.ll to llvm/test/MC/AArch64/ and modify it accordingly. The test is kind of in the wrong location, though. It should really be in llvm/test/CodeGen/(X86|AArch64), since it's an llc test.



================
Comment at: include/llvm/CodeGen/TargetLoweringObjectFileImpl.h:167-168
+
+  const MCExpr *
+    lowerRelativeReference(const GlobalValue *LHS, const GlobalValue *RHS,
+                           const TargetMachine &TM) const override;
----------------
This doesn't look like something clang-format would produce, consider running `git clang-format` to reformat the lines touched in the patch.


https://reviews.llvm.org/D47783