[PATCH] D47795: commandLineFitsWithinSystemLimits Overestimates System Limits

[Austin Belknap via Phabricator via llvm-commits]

dabelknap added a comment.

The possibility of writing a test for this isn't clear to me. I basically had to do an integration test with `clang` and scan through different command line lengths to search for failures (See the Gist). In the case of a failure, that script //should// terminate within a few minutes since it uses a large step-size (this could in principle, miss a failure). If there are no failures, scanning through the entire range of command line lengths with a small step size would take an unreasonably long time (in some cases days, if multiprocessing is not used). To further complicate matters, it is machine-dependent. I'm certainly open to suggestions if anyone has any ideas.

Also, thanks for getting to this quickly. Do you have someone in mind for reviewing this?


https://reviews.llvm.org/D47795