[PATCH] D47785: [llvm-exegesis] Serializes instruction's operand in BenchmarkResult's key.
Clement Courbet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 6 04:43:17 PDT 2018
courbet added inline comments.
================
Comment at: tools/llvm-exegesis/lib/BenchmarkResult.cpp:44
+ assert(!String.empty());
+ // Starts with an uppercase, this is a Register.
+ if (std::isupper(String.front()))
----------------
this won't work for arm/power.
================
Comment at: tools/llvm-exegesis/lib/BenchmarkResult.cpp:47
+ return llvm::MCOperand::createReg(Context.getRegNo(String));
+ // There's a dot, this is a floating point.
+ if (String.count('.')) {
----------------
Really ? :D
Then use a custom format in serialize(), else this will not work. You also need to make sure that you're using the ansi C locale.
Repository:
rL LLVM
https://reviews.llvm.org/D47785
More information about the llvm-commits
mailing list