[PATCH] D47818: [llvm-strip] Expose --strip-unneeded option

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with the suggested changes.



================
Comment at: test/tools/llvm-objcopy/strip-unneeded.test:7
 # RUN: llvm-readobj -symbols %t2 | FileCheck %s
+# Verify that llvm-strip modifies the symbol table the same way.
+# RUN: cp %t %t3
----------------
Please put a new line in before this line. It'll help make the llvm-strip part clearer.


================
Comment at: test/tools/llvm-objcopy/strip-unneeded.test:8-9
+# Verify that llvm-strip modifies the symbol table the same way.
+# RUN: cp %t %t3
+# RUN: llvm-strip --strip-unneeded %t3
+# RUN: cmp %t2 %t3
----------------
You don't need to copy the input file here, since we don't use it again at this point.


================
Comment at: tools/llvm-objcopy/llvm-objcopy.cpp:586
 
   // Strip debug info only.
   Config.StripDebug = InputArgs.hasArg(STRIP_strip_debug);
----------------
This comment looks a little out of place now with the changes you and @alexshap are making in this area. It probably needs updating or (re)moving.


Repository:
  rL LLVM

https://reviews.llvm.org/D47818