[PATCH] D47266: Update thin-lto cache file atimes when on windows

[David Major via Phabricator via llvm-commits]

dmajor added a comment.

I don't know this code well enough to be a proper reviewer, but I want to offer moral support for this change. Not having atime updates on NTFS can be frustrating at times.



================
Comment at: include/llvm/Support/FileSystem.h:854
+                                SmallVectorImpl<char> *RealPath = nullptr,
+                                bool ForceUpdateAtime = false);
 
----------------
Needs a @param


================
Comment at: lib/Support/Windows/Path.inc:1099
+    if (std::error_code EC = updateAccessTime(H))
+      return EC;
+  }
----------------
This needs a CloseHandle here, right?


Repository:
  rL LLVM

https://reviews.llvm.org/D47266